Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#11138 closed (fixed)

Minor errors in ModelForm documentation

Reported by: anonymous Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: ModelForm
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I've noted the following minor errors in

http://docs.djangoproject.com/en/dev/topics/forms/modelforms/

(1) In the "Overiding clean() on a model_formset" section, there are two little errors in the following sentence :

"...by default the clean() method of a model_formset will validate that none of the items in the formset validate the unique constraints on your model(either unique or unique_together)."

(a) the second occurrence of "validate" should be "violate"

(b) there should be a space before the parenthesis in "model(either".

(2) In the "Limiting the number of editable objects", the word "less" should be changed to "more" in the following sentence:

"If the value of max_num is less than the total objects returned, the formset will fill the rest with extra forms:"

It should read

"If the value of max_num is more than the total objects returned,..."

or else

"If the total number of objects returned is less than max_num,..."

Change History (4)

comment:1 Changed 6 years ago by kmtracey

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Both parts of (1) were fixed yesterday by r10795/r10796.

(2) could use some more general rewording, I think. "the formset will fill the rest with extra forms" sounds like you might get max_num forms even if the number of existing objects + extra parameter is less than max_num, which isn't the case.

comment:2 Changed 6 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

(In [10819]) Fixed #11138 -- Corrected the description of behavior related to the max_num parameter for model formsets.

comment:3 Changed 6 years ago by kmtracey

(In [10820]) [1.0.X] Fixed #11138 -- Corrected the description of behavior related to the max_num parameter for model formsets.

r10819 from trunk.

comment:4 Changed 4 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top