Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#11123 closed (fixed)

Irish localflavor

Reported by: Michael Thornhill Owned by: nobody
Component: contrib.localflavor Version: 1.0
Severity: Keywords: Ireland ie
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Irish localflavor contribution with county names

Attachments (1)

ie.tar.gz (797 bytes) - added by Michael Thornhill 7 years ago.
ie localflavor with County removed from all county names and unneccesary imports removed

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Russell Keith-Magee

milestone: 1.1
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Thanks for the contribution. However, the feature deadline for v1.1 has passed; we can look at this for the next release.

comment:2 Changed 7 years ago by dc

Patch needs improvement: set

forms.py imports many things but only django.forms.fields.Select is required

comment:3 Changed 7 years ago by Michael Thornhill

Has patch: set
Patch needs improvement: unset

Improved patch by removing unnecessary imports from forms.py and removed unnecessary country string from all counties

Changed 7 years ago by Michael Thornhill

Attachment: ie.tar.gz added

ie localflavor with County removed from all county names and unneccesary imports removed

comment:4 Changed 7 years ago by anonymous

milestone: 1.2

comment:5 Changed 7 years ago by Russell Keith-Magee

One quick question before I commit - Is there any sort of official abbreviation or enumeration that is (or could be) used for county names? (e.g., Australia uses "NSW" for New South Wales, "QLD" for Queensland, etc)

If no such abbreviation/enumeration exists, thats fine - Finnish municipalities are in the same category, for example. I just want to make sure that my ignorance of Irish municipal conventions doesn't lead to committing an enumeration where there might be a more efficient internal representation.

comment:6 Changed 7 years ago by Michael Thornhill

Hi Russell,
No such official abbreviation or enumeration exists for Irish County names.
Thanks
Michael

comment:7 Changed 7 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

(In [12043]) Fixed #11123 - Added Irish (ie) localflavor.

comment:8 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top