Code

Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#11123 closed (fixed)

Irish localflavor

Reported by: mt Owned by: nobody
Component: contrib.localflavor Version: 1.0
Severity: Keywords: Ireland ie
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Irish localflavor contribution with county names

Attachments (1)

ie.tar.gz (797 bytes) - added by mt 5 years ago.
ie localflavor with County removed from all county names and unneccesary imports removed

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by russellm

  • milestone 1.1 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Thanks for the contribution. However, the feature deadline for v1.1 has passed; we can look at this for the next release.

comment:2 Changed 5 years ago by dc

  • Patch needs improvement set

forms.py imports many things but only django.forms.fields.Select is required

comment:3 Changed 5 years ago by mt

  • Has patch set
  • Patch needs improvement unset

Improved patch by removing unnecessary imports from forms.py and removed unnecessary country string from all counties

Changed 5 years ago by mt

ie localflavor with County removed from all county names and unneccesary imports removed

comment:4 Changed 5 years ago by anonymous

  • milestone set to 1.2

comment:5 Changed 4 years ago by russellm

One quick question before I commit - Is there any sort of official abbreviation or enumeration that is (or could be) used for county names? (e.g., Australia uses "NSW" for New South Wales, "QLD" for Queensland, etc)

If no such abbreviation/enumeration exists, thats fine - Finnish municipalities are in the same category, for example. I just want to make sure that my ignorance of Irish municipal conventions doesn't lead to committing an enumeration where there might be a more efficient internal representation.

comment:6 Changed 4 years ago by mt

Hi Russell,
No such official abbreviation or enumeration exists for Irish County names.
Thanks
Michael

comment:7 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [12043]) Fixed #11123 - Added Irish (ie) localflavor.

comment:8 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.