Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#11113 closed (fixed)

Multiple issues with contrib.comments moderation system

Reported by: ubernostrum Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I know it's really bad form to condense multiple things into one ticket, but here goes anyway.

  1. django.contrib.comments.moderation currently listens for the pre_save and post_save signals, which means the moderation system misses out on important additional information available from the custom signals defined inside the comments application.
  2. moderation.py currently contains some experimental code that I never documented, never tested and never shipped in any version of comment-utils. That code should not be shipping in Django.

The attached patch deals with both of these issues, updates the relevant documentation and has passing tests.

Attachments (1)

comment-moderation-signals.diff (15.8 KB) - added by ubernostrum 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by ubernostrum

comment:1 Changed 6 years ago by ubernostrum

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10784]) Fixed #11113: fixed a couple of issues that slipped through the cracks when comment moderation was added to django.contrib.comments.

The is a potentially backwards-incompatible change for users already relying on the internals of comment moderaration. To wit:

  • The moderation system now listens to the new comment_will_be_posted/comment_was_posted signals instead of pre/post_save. This means that import request-based information is available to moderation as it should be.
  • Some experimental code from django.contrib.comments.moderation has been removed. It was never intended to be merged into Django, and was completely untested and likely buggy.

comment:3 Changed 4 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top