Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#11106 closed (fixed)

typo in documentation?

Reported by: mnieber Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: typo
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by Alex Gaynor)

I think in http://docs.djangoproject.com/en/dev/topics/db/models/#topics-db-models

>>> Groups.objects.filter(members__name__startswith='Paul')

should be

>>> Group.objects.filter(members__name__startswith='Paul')

Moreover, memberships for paul and ringo are created differently:

m1 = Membership(person=ringo, group=beatles, date_joined=date(1962, 8, 16), invite_reason= "Needed a new drummer.")
m2 = Membership.objects.create(person=paul, group=beatles, date_joined=date(1960, 8, 1), invite_reason= "Wanted to form a band.")

Only the second version (using Membership.objects.create) seems to work.

>>> for group in Group.objects.all():
...    print group.name 
...    print group.members.all()

The Beatles
[<Person: Paul McCartney>]

Attachments (1)

11106.diff (555 bytes) - added by Tim Graham 7 years ago.
typo

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by Alex Gaynor

Description: modified (diff)
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Fixed formatting.

comment:2 Changed 7 years ago by Ramiro Morales

> Moreover, memberships for paul and ringo are created differently:
> 
> m1 = Membership(person=ringo, group=beatles, date_joined=date(1962, 8, 16), invite_reason= "Needed a new drummer.")
> [...]
> m2 = Membership.objects.create(person=paul, group=beatles, date_joined=date(1960, 8, 1), invite_reason= "Wanted to form a band.")
> 
> Only the second version (using Membership.objects.create) seems to work. 

That's because you forgot about the m1.save() just below the first line, x = Model(...); x.save() and Model.objects.create() are equivalent.

Changed 7 years ago by Tim Graham

Attachment: 11106.diff added

typo

comment:3 Changed 7 years ago by Tim Graham

Has patch: set
Keywords: typo added
Triage Stage: UnreviewedReady for checkin

comment:4 Changed 7 years ago by Karen Tracey

Resolution: fixed
Status: newclosed

(In [10797]) Fixed #11106 -- Corrected typo in models doc. Thanks mnieber.

comment:5 Changed 7 years ago by Karen Tracey

(In [10798]) [1.0.X] Fixed #11106 -- Corrected typo in models doc. Thanks mnieber.

r10797 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top