Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#11057 closed (fixed)

No actions in admin (actions=None) messes up layout.

Reported by: rvdrijst Owned by: nobody
Component: contrib.admin Version: dev
Severity: Keywords: actions=None actions admin style
Cc: rvdrijst@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When a changelist page on the admin has no actions to display and therefore no checkboxes to put in the first column of each row, the layout of the columns is mangled. This is because the styles in changelists.css use the first-child selector and set the width of that first column to 1.5em. This is fine when it is indeed a checkbox column, but makes it rather difficult to fit in text of any reasonable size when it is not.

The attached patch solves the problem by setting a special class attribute 'action-checkbox-column' on the header for the action checkboxes and the width of 1.5em only applies to that class. There are also two simple tests.

This bug arises because of an incomplete implementation of ticket #10595.

Attachments (1)

actions_patch.diff​ (2.3 KB ) - added by rvdrijst 15 years ago.
Patch with fix and tests

Download all attachments as: .zip

Change History (4)

by rvdrijst, 15 years ago

Attachment: actions_patch.diff​ added

Patch with fix and tests

comment:1 by Alex Gaynor, 15 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Jacob, 15 years ago

Resolution: → fixed
Status: new → closed

(In [11670]) Fixed #11057: having no actions in the admin (actions=None) no longer messes up the layout. Thanks, rvdrijst.

comment:3 by Jacob, 15 years ago

(In [11671]) [1.1.X] Fixed #11057: having no actions in the admin (actions=None) no longer messes up the layout. Thanks, rvdrijst.

Backport of [11670] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top