Code

Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#11044 closed (fixed)

FormWizard extra_context attribute is class-wide

Reported by: taylanpince Owned by: nobody
Component: contrib.formtools Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

FormWizard's extra_context attribute is declared within the class, rather than the init method, which means that it persists across the class, causing data within the extra_context to appear in all requests. Patch attached to move the declaration inside init.

Attachments (1)

formwizard_extra_context_fix.diff (905 bytes) - added by taylanpince 5 years ago.
Patch to move extra_context declaration under init

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by taylanpince

Patch to move extra_context declaration under init

comment:1 Changed 4 years ago by russellm

  • milestone set to 1.2
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 4 years ago by ramiro

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [12644] (that has a typo in the commit message), backported to the 1.1.X branch in [12645].

comment:3 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.