Opened 15 years ago
Closed 13 years ago
#11020 closed Uncategorized (wontfix)
models.permalink() does not pass through the url prefix
| Reported by: | Holger Just | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 1.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Design decision needed | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The permalink() decorator does not allow for passing a customized prefix to the reverse() function. The attached patch changes that behavior by allowing an additional positional parameter to be passed to the reverse function.
I originally wanted to use that feature to generate fully qualified URLs to switch between HTTPS and plain HTTP.
Attachments (1)
Change History (3)
by , 15 years ago
| Attachment: | permalink.patch added |
|---|
comment:1 by , 15 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Design decision needed |
You don't have to use the permalink decorator. It feels like this is an edge case that could just use a reverse() call, but I'll push to a design decision rather than close outright.
comment:2 by , 13 years ago
| Resolution: | → wontfix |
|---|---|
| Severity: | → Normal |
| Status: | new → closed |
| Type: | → Uncategorized |
The prefix arg isn't even documented and it's definitely an edge case so I'm going to close this as won't fix.
Note:
See TracTickets
for help on using tickets.
Patch to fix the permalink behavior