Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#1102 closed defect (fixed)

[patch] a few HTML errors in the admin app

Reported by: L.Plant.98@… Owned by: adrian
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This patch addresses 3 HTML errors in the admin (as of rev 1764, trunk).

Attachments (1)

django_admin_html_patch_1.diff (1.7 KB) - added by L.Plant.98@… 10 years ago.
patch

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by L.Plant.98@…

patch

comment:1 Changed 10 years ago by adrian

Thanks for this patch. What's the extra <div> for in the search_form.html template?

comment:2 Changed 10 years ago by L.Plant.98@…

Apparently <form> can only contain block or script elements:
http://www.w3.org/TR/REC-html40/interact/forms.html#edef-FORM

so you can't put an <input> or <label> inside <form> directly, but adding a div fixes it.

comment:3 Changed 10 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [1791]) Fixed #1102 -- Fixed some HTML validation errors in admin templates. Thanks, Luke Plant

Note: See TracTickets for help on using tickets.
Back to Top