Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#10997 closed (fixed)

Admin backend uses `set` without the Python 2.3 fallback

Reported by: anonymous Owned by: Tarken
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

in line 38 of admin.actions.py:

perms_needed = set()

it gets error:

global name 'set' is not defined

with python 2.3.4

Attachments (1)

10997.diff (546 bytes) - added by Tarken 6 years ago.
Simple enough patch. Shouldn't be any docs/tests required. Pulled this straight from options.py

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to anonymous
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 6 years ago by anonymous

  • Owner anonymous deleted
  • Status changed from assigned to new

Changed 6 years ago by Tarken

Simple enough patch. Shouldn't be any docs/tests required. Pulled this straight from options.py

comment:3 Changed 6 years ago by Tarken

  • Has patch set

comment:4 Changed 6 years ago by Tarken

  • Owner set to Tarken
  • Status changed from new to assigned

Not that I want to make the 1.1 bug list any bigger, but should this be on there?

comment:5 Changed 6 years ago by russellm

  • milestone set to 1.1

comment:6 Changed 6 years ago by Alex

  • Triage Stage changed from Unreviewed to Ready for checkin

comment:7 Changed 6 years ago by Alex

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r10705.

comment:8 Changed 4 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top