#1099 closed enhancement (wontfix)
[patch] Enable usage of absolute path for admin js option
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.admin | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | nesh@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
With this patch if admin.js parameter is used with absolute URL, ADMIN_MEDIA_URL is not added in front of it.
This way we don't need to link additional JS files into ADMIN_MEDIA_URL/js/ directory.
Attachments (2)
Change History (7)
by , 19 years ago
| Attachment: | admin.diff added |
|---|
comment:1 by , 19 years ago
| Cc: | added |
|---|
comment:2 by , 19 years ago
comment:3 by , 19 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
We're going to remove the admin.js option entirely, in favor of custom admin templates, so I'm marking this as a wontfix.
by , 19 years ago
| Attachment: | admin_media_prefix_allow_absolute_paths.diff added |
|---|
My take on the fix for this issue; supports http(s): and uses urljoin.
comment:4 by , 19 years ago
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
I thought I'd add my crack at this issue; as it's been three months since this ticket was closed, and it's still an annoying issue today (IMHO), I don't feel that applying a fix right now would be detrimental unless those custom admin templates are arriving tomorrow. :)
comment:5 by , 18 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
Forgive me, for I know not what I was high on; custom admin templates are indeed a much better solution, as I've discovered. :-D
It would also be good (and trivial) to be able to specify a full url, ie. http://somesite.com/scripts/somescript.js