Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#1099 closed enhancement (wontfix)

[patch] Enable usage of absolute path for admin js option

Reported by: Nebojša Đorđević - nesh <nesh@…> Owned by: adrian
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: nesh@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

With this patch if admin.js parameter is used with absolute URL, ADMIN_MEDIA_URL is not added in front of it.

This way we don't need to link additional JS files into ADMIN_MEDIA_URL/js/ directory.

Attachments (2)

admin.diff (925 bytes) - added by Nebojša Đorđević - nesh <nesh@…> 9 years ago.
admin_media_prefix_allow_absolute_paths.diff (842 bytes) - added by Tom Tobin <korpios@…> 9 years ago.
My take on the fix for this issue; supports http(s): and uses urljoin.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Nebojša Đorđević - nesh <nesh@…>

comment:1 Changed 9 years ago by Nebojša Đorđević - nesh <nesh@…>

  • Cc nesh@… added

comment:2 Changed 9 years ago by joeboy

It would also be good (and trivial) to be able to specify a full url, ie. http://somesite.com/scripts/somescript.js

comment:3 Changed 9 years ago by adrian

  • Resolution set to wontfix
  • Status changed from new to closed

We're going to remove the admin.js option entirely, in favor of custom admin templates, so I'm marking this as a wontfix.

Changed 9 years ago by Tom Tobin <korpios@…>

My take on the fix for this issue; supports http(s): and uses urljoin.

comment:4 Changed 9 years ago by Tom Tobin <korpios@…>

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I thought I'd add my crack at this issue; as it's been three months since this ticket was closed, and it's still an annoying issue today (IMHO), I don't feel that applying a fix right now would be detrimental unless those custom admin templates are arriving tomorrow. :)

comment:5 Changed 9 years ago by Tom Tobin <korpios@…>

  • Resolution set to wontfix
  • Status changed from reopened to closed

Forgive me, for I know not what I was high on; custom admin templates are indeed a much better solution, as I've discovered. :-D

Note: See TracTickets for help on using tickets.
Back to Top