Opened 14 years ago
Closed 9 years ago
#10935 closed Cleanup/optimization (fixed)
forms.ImageField.clean should annotate the object returned by FileField.clean
| Reported by: | Jeremy Dunck | Owned by: | petraszd |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
ImageField.clean does some validation that the given file is, in fact, an image, but then just returns whatever the FileField gave it-- generally an UploadedFile.
I have a later Form.clean_* method which needs to do further work with the image, and so uses Image.open again.
I think it'd be good to annotate the UploadedFile with an image attribute to save the work of parsing the image yet again.
f.image = trial_image
Agree?
Change History (14)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
| Triage Stage: | Unreviewed → Design decision needed |
|---|
comment:3 Changed 14 years ago by
| milestone: | 1.2 → 1.3 |
|---|
I'm calling this a feature, and kicking it out of 1.2.
comment:5 Changed 12 years ago by
| Severity: | → Normal |
|---|---|
| Type: | → Cleanup/optimization |
comment:8 Changed 11 years ago by
| Triage Stage: | Design decision needed → Accepted |
|---|
comment:9 Changed 9 years ago by
| Owner: | changed from nobody to petraszd |
|---|---|
| Status: | new → assigned |
comment:10 Changed 9 years ago by
| Has patch: | set |
|---|
Pull request: https://github.com/django/django/pull/2972
comment:11 Changed 9 years ago by
| Needs documentation: | unset |
|---|
comment:12 Changed 9 years ago by
| Patch needs improvement: | set |
|---|
comment:13 Changed 9 years ago by
| Patch needs improvement: | unset |
|---|
Updated pull request according to comments in github. And now it also included setting content_type by using information Pillow provides.
comment:14 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
In 8b7347220f3d86b46f5f87270c6cdcb9960895fd:
Fixed #10935 -- Annotated ImageField file with image and content_type attributes.
Thanks Jeremy Dunck for the suggestion and Nick Sanford for review.
Also, as long as it's opening the image, I think it should correct content_type based on the actual format of the image. Most OS's will mis-report the content type of the upload based on its extension, so that a JPEG named something.gif is reported as image/gif.