Code

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#10917 closed New feature (fixed)

admin/base.html should contain messages block

Reported by: anonymous Owned by: nobody
Component: contrib.admin Version:
Severity: Normal Keywords: admin customization block messages
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

The admin/base.html template should surround messages with a block to allow customization in base_site.html.

{% block messages %}
{% if messages %}
<ul class="messagelist">{% for message in messages %}<li>{{ message }}</li>{% endfor %}</ul>
{% endif %}
{% endblock %}

Attachments (2)

base.html.diff (876 bytes) - added by Philomat 4 years ago.
svn diff
10917.admin-messages-block.diff (881 bytes) - added by julien 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by thejaswi_puthraya

  • Component changed from Uncategorized to django.contrib.admin
  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset

comment:2 Changed 5 years ago by lukeplant

  • Needs tests unset
  • Patch needs improvement set

Patch needs to be "unified" style. Using svn diff from base django directory is the easiest.

Changed 4 years ago by Philomat

svn diff

comment:3 Changed 4 years ago by Philomat

  • Has patch set

I second that. Really useful for integrating apps like django_notify

comment:4 Changed 4 years ago by anonymous

  • Patch needs improvement unset

comment:5 Changed 4 years ago by russellm

  • Triage Stage changed from Unreviewed to Accepted

comment:6 Changed 3 years ago by julien

  • milestone set to 1.4
  • Patch needs improvement set

The patch looks good, though it doesn't apply any more. This new feature comes too late for 1.3 but I'd like to see it in 1.4.

comment:7 Changed 3 years ago by SmileyChris

  • Severity set to Normal
  • Type set to New feature
  • Version 1.1-beta-1 deleted

Agreed.

Changed 3 years ago by julien

comment:8 Changed 3 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

Updated the patch so it applies to current trunk. I think it's ready to go.

comment:9 Changed 3 years ago by lukeplant

  • Resolution set to fixed
  • Status changed from new to closed

In [16046]:

Fixed #10917 - admin/base.html should contain messages block

Thanks to Philomat/julien for the patch

comment:10 Changed 3 years ago by jacob

  • milestone 1.4 deleted

Milestone 1.4 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.