#10917 closed New feature (fixed)
admin/base.html should contain messages block
| Reported by: | anonymous | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | |
| Severity: | Normal | Keywords: | admin customization block messages |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
The admin/base.html template should surround messages with a block to allow customization in base_site.html.
{% block messages %}
{% if messages %}
<ul class="messagelist">{% for message in messages %}<li>{{ message }}</li>{% endfor %}</ul>
{% endif %}
{% endblock %}
Attachments (2)
Change History (12)
comment:1 by , 16 years ago
| Component: | Uncategorized → django.contrib.admin |
|---|---|
| Needs tests: | set |
comment:2 by , 15 years ago
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | set |
comment:3 by , 15 years ago
| Has patch: | set |
|---|
I second that. Really useful for integrating apps like django_notify
comment:4 by , 15 years ago
| Patch needs improvement: | unset |
|---|
comment:5 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:6 by , 14 years ago
| milestone: | → 1.4 |
|---|---|
| Patch needs improvement: | set |
The patch looks good, though it doesn't apply any more. This new feature comes too late for 1.3 but I'd like to see it in 1.4.
by , 14 years ago
| Attachment: | 10917.admin-messages-block.diff added |
|---|
comment:8 by , 14 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Updated the patch so it applies to current trunk. I think it's ready to go.
Note:
See TracTickets
for help on using tickets.
Patch needs to be "unified" style. Using svn diff from base django directory is the easiest.