Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#10917 closed New feature (fixed)

admin/base.html should contain messages block

Reported by: anonymous Owned by: nobody
Component: contrib.admin Version:
Severity: Normal Keywords: admin customization block messages
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

The admin/base.html template should surround messages with a block to allow customization in base_site.html.

{% block messages %}
{% if messages %}
<ul class="messagelist">{% for message in messages %}<li>{{ message }}</li>{% endfor %}</ul>
{% endif %}
{% endblock %}

Attachments (2)

base.html.diff (876 bytes) - added by Philomat 7 years ago.
svn diff
10917.admin-messages-block.diff (881 bytes) - added by Julien Phalip 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Thejaswi Puthraya

Component: Uncategorizeddjango.contrib.admin
Needs documentation: unset
Needs tests: set
Patch needs improvement: unset

comment:2 Changed 7 years ago by Luke Plant

Needs tests: unset
Patch needs improvement: set

Patch needs to be "unified" style. Using svn diff from base django directory is the easiest.

Changed 7 years ago by Philomat

Attachment: base.html.diff added

svn diff

comment:3 Changed 7 years ago by Philomat

Has patch: set

I second that. Really useful for integrating apps like django_notify

comment:4 Changed 7 years ago by anonymous

Patch needs improvement: unset

comment:5 Changed 7 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

comment:6 Changed 6 years ago by Julien Phalip

milestone: 1.4
Patch needs improvement: set

The patch looks good, though it doesn't apply any more. This new feature comes too late for 1.3 but I'd like to see it in 1.4.

comment:7 Changed 5 years ago by Chris Beaven

Severity: Normal
Type: New feature
Version: 1.1-beta-1

Agreed.

Changed 5 years ago by Julien Phalip

comment:8 Changed 5 years ago by Julien Phalip

Triage Stage: AcceptedReady for checkin

Updated the patch so it applies to current trunk. I think it's ready to go.

comment:9 Changed 5 years ago by Luke Plant

Resolution: fixed
Status: newclosed

In [16046]:

Fixed #10917 - admin/base.html should contain messages block

Thanks to Philomat/julien for the patch

comment:10 Changed 5 years ago by Jacob

milestone: 1.4

Milestone 1.4 deleted

Note: See TracTickets for help on using tickets.
Back to Top