Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10898 closed (fixed)

Bugs in 'conditional view processing' doc

Reported by: tomasz.elendt Owned by: nobody
Component: Documentation Version: 1.1-beta
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

First of all there's bug in code sample in latest_entry function, which should returns datetime object instead of dict. There's also one typo (last_modified instead of last_modified_func).

Attachments (1)

conditional_view_processing.diff (1.2 KB) - added by tomasz.elendt 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by tomasz.elendt

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by mtredinnick

The second part of the patch cannot be correct, since datetime objects don't have a method called get() that operates like a queryset. Looks like you probably also want to change aggregate() to annotate() there, since the latter has a different return type (a queryset).

comment:3 Changed 5 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [10642]) Fixed #10898 -- Corrected minor error in conditional view processing example. Thanks to Tomasz Elendt for the report.

comment:4 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.