FormWizard process_step receives yet to be validated form for previous steps
|Reported by:||graham.carlyle@…||Owned by:||jashugan|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||yes||Patch needs improvement:||no|
The docs for FormWizard process_step state that "The Form is guaranteed to have clean, valid data." and so you might assume that the form it supplies is ready to use when passed to this method. However its only the current step that gets a form that has the cleaned_data property immediately accessible, whereas previous steps require the form.is_valid method to be called.
So it seems that the code should call is_valid on forms from previous steps before passing the form to process_step. Presumably as the docs state the form would always be valid and if not then somehow the hash has been defeated.
Change History (5)
Changed 5 years ago by jashugan
comment:1 Changed 5 years ago by jashugan
- Has patch set
- Needs documentation unset
- Needs tests set
- Owner changed from nobody to jashugan
- Patch needs improvement unset
- Status changed from new to assigned