Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#10878 closed (fixed)

Comments moderation.py docstring error

Reported by: Luca Lenardi Owned by: James Bennett
Component: contrib.comments Version: 1.1-beta
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It seems that "Moderator" should be used in place of "CommentModerator" at line 310 in django.contrib.comments.moderation.py docstring.

Attachments (1)

10878-r11858.diff (1.2 KB) - added by Travis Cline <travis.cline@…> 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by James Bennett

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to James Bennett
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedAccepted

This will be fixed by a much larger patch to comments that I'm preparing.

comment:2 Changed 7 years ago by Fantomas42

Hi,

I enjoy that you are preparing a big patch.

Is this patch will includes,

  • translations of the mail_subject, when sending email ?
  • the pre_save_moderation method with the request in parameters, with comment_will_be_posted signal for exemple ?

It's just some suggestions that I've made with the usage of the moderation.py

comment:3 Changed 7 years ago by Adrian Holovaty

milestone: 1.11.2

Changed 7 years ago by Travis Cline <travis.cline@…>

Attachment: 10878-r11858.diff added

comment:4 Changed 7 years ago by Travis Cline <travis.cline@…>

Has patch: set

comment:5 Changed 7 years ago by Eric Holscher

Triage Stage: AcceptedReady for checkin

comment:6 Changed 7 years ago by Jacob

Resolution: fixed
Status: assignedclosed

(In [12639]) Fixed #10878, an error in the Moderator docstring.

Thanks, Travis Cline.

comment:7 Changed 7 years ago by Jacob

(In [12640]) [1.1.X] Fixed #10878, an error in the Moderator docstring.

Thanks, Travis Cline.

Backport of [12639] from trunk.

comment:8 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top