Code

Opened 5 years ago

Closed 5 years ago

#10860 closed (invalid)

Invalid paragraph tag in comments preview template

Reported by: justquick Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: comments html
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A single <p> tag in comments/preview.html was not closed. It is a very small problem, im just being a perfectionist. Thanks so much for this great framework!

Attachments (1)

preview.html.diff (614 bytes) - added by justquick 5 years ago.
svn diff output

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by justquick

svn diff output

comment:1 Changed 5 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

There are 3 <p> tags in here, all of them appear to have been closed: http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/templates/comments/preview.html . Can you show where you see the unclosed one?

comment:2 Changed 5 years ago by justquick

The patch is pretty clear which one it is, but the one im looking at is on line 24 and its the only html on that line.

comment:3 Changed 5 years ago by justquick

Just looked at the form.html as well http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/templates/comments/form.html. Same problem, line 9. This made me think that possibly there were others in comments templates, so i just checked and its only in form.html and preview.html. Feel free to double check me (grep '<p' django/contrib/comments/templates/comments/*.html)

comment:4 Changed 5 years ago by justquick

  • Resolution set to invalid
  • Status changed from new to closed

No wait, I was not lookin at this right. False alarm, sorry guys

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.