Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#10831 closed (fixed)

Using autocommit transaction decorator with new-style TestCase can lead to incorrect DB commit

Reported by: Sean Legassick Owned by: Karen Tracey
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The autocommit transaction decorator calls transaction.managed(False) which can under some circumstances cause a DB commit. Thus the managed function should be nop'd like the other transaction functions (see attached patch) to avoid unwanted commits whilst running new-style TestCase tests.

Attachments (1)

10831-test-case-nops-out-transaction-managed-func.diff (1.1 KB) - added by Sean Legassick 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Sean Legassick

comment:1 Changed 8 years ago by Karen Tracey

milestone: 1.1
Owner: changed from nobody to Karen Tracey
Status: newassigned
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by Karen Tracey

Resolution: fixed
Status: assignedclosed

(In [10621]) Fixed #10831 -- Prevented code running under a to-be-rolled-back test from calling commit via transaction.managed(False). Thanks seanl for report and patch.

comment:3 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top