Template filter date 'U' raises an AttributeError under certain circumstances

[Matthias Kestenholz]

While fixing #10048 in [9919] a new bug has been introduced. Around line 200 in django/utils/dateformat.py:

    def U(self):
        "Seconds since the Unix epoch (January 1 1970 00:00:00 GMT)"
        off = self.timezone and self.timezone.utcoffset(self.data) or 0
        return int(time.mktime(self.data.timetuple())) + off.seconds * 60

If self.timezone and self.timezone.utfoffset(self.data) evaluates to False, Django tries to access off.seconds but off is 0 => An AttributeError (int has no attribute seconds) is raised.

Unfortunately I do not know enough about the timezone handling to provide a test or even a fix.

[Karen Tracey]

See also #9850. Note U is documented as "not implemented" and near as I can tell the code before this change didn't work properly either (though I guess perhaps it didn't raise an AttributeError).

[George Song]

'U' implementation, tests, and documentation

[George Song]

Same as last patch, but removed unnecessary self.timezone check

[George Song]

Provided patch to let Python do its timezone thing, instead of futzing with offsets, etc.

[Matthias Kestenholz]

This patch works for me, thanks.

[Michael Radziej]

the patch breaks the dateformat tests. I'm fixing ...

[Michael Radziej]

patch inluding fix of testcases, replaces older patch

[Michael Radziej]

Fix issues with epoch values in util.datetime.

• fix handling of data without timezone
• fix handling of time zones and DST (you really should not multiply seconds in the first place!)

I double-checked that this now gives correct results with other services on the Internet.

[Jacob]

(In [10716]) Fixed #10825: fixed the 'U' format code to dateformat (and the date/now filter/tag). Thanks to gsong and mir.

[Jacob]

Milestone 1.1 deleted