Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10773 closed (fixed)

3 letters french translation of August use 4 chars

Reported by: djoume Owned by: nobody
Component: Translations Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

According to the documentation:

http://docs.djangoproject.com/en/dev/ref/templates/builtins/#now

b Month, textual, 3 letters, lowercase.

However the French translation for the month of August is currently "aout" (4 chars).

This cause an url pattern like (?P<month>\w\w\w) to throw a NoReverseMatch in French.

The attached patch fix the issue.

Attachments (2)

fix-french-translation-3-letters-august.diff (353 bytes) - added by djoume 5 years ago.
french translation update
10773.diff (510 bytes) - added by kmtracey 5 years ago.

Download all attachments as: .zip

Change History (15)

Changed 5 years ago by djoume

french translation update

comment:1 Changed 5 years ago by julien

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [10508]) Fixed #10773 -- Small fix to the French translation. Thanks, djoume.

comment:3 Changed 5 years ago by mtredinnick

(In [10509]) [1.0.X] Fixed #10773 -- Small fix to the French translation. Thanks, djoume.

Backport of r10508 from trunk.

comment:4 Changed 5 years ago by stephaner

  • Component changed from Uncategorized to Translations
  • Resolution fixed deleted
  • Status changed from closed to reopened

mtredinnick,

You didn't apply the right fix, you've mix up 'aug' and 'August'!

comment:5 Changed 5 years ago by Ahmed Zouari

  • Resolution set to fixed
  • Status changed from reopened to closed

Please reverse change 10509
and
apply patch

comment:6 Changed 5 years ago by Alex

  • Resolution fixed deleted
  • Status changed from closed to reopened

This has not been fixed.

comment:7 follow-up: Changed 5 years ago by kmtracey

Added a patch that restores the full "August" translation and uses 3-char abbr. for both "aug" and "Aug.". Not sure whether that last one is correct though since it wasn't part of the original request -- can anyone with better knowledge of French than me either confirm or explain why you wouldn't want to consistently abbreviate it?

comment:8 in reply to: ↑ 7 Changed 5 years ago by julien

Replying to kmtracey:

Added a patch that restores the full "August" translation and uses 3-char abbr. for both "aug" and "Aug.". Not sure whether that last one is correct though since it wasn't part of the original request -- can anyone with better knowledge of French than me either confirm or explain why you wouldn't want to consistently abbreviate it?

Karen, your patch is correct except for msgid "Aug." which shouldn't be changed (it should remain "août"). This is because August in French only has 4 letters and so it doesn't need to be abbreviated (since "Aug." also has 4 characters).

However, I've noticed something strange. Why is April not abbreviated? There is no msgid "Apr."...

Changed 5 years ago by kmtracey

comment:9 follow-up: Changed 5 years ago by kmtracey

OK, thanks, I fixed the patch to not mess with the "Aug." translation. Based on where the string comes from, actually, I see it isn't a 3-letter abbreviation, really, it's just the Associated Press style name. Apparently AP abbreviates only months with more than 5 chars in their name, so March, April, May, June, and July don't get abbreviated, plus September gets a 4-letter abbr. instead of 3 like the rest that get abbreviated.

comment:10 Changed 5 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10595]) Fixed #10773 -- Fixed some damage I did to the French in r10508.

Patch from Karen Tracey.

comment:11 Changed 5 years ago by mtredinnick

(In [10596]) [1.0.X] Fixed #10773 -- Fixed some damage I did to the French in r10509.

Patch from Karen Tracey.

Backport of r10595 from trunk.

comment:12 in reply to: ↑ 9 Changed 5 years ago by stephaner

Replying to kmtracey:

The problem brought up by julien and kmtracey is already reported by #9988.

comment:13 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.