Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#10773 closed (fixed)

3 letters french translation of August use 4 chars

Reported by: Djoume Salvetti Owned by: nobody
Component: Translations Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

According to the documentation:

http://docs.djangoproject.com/en/dev/ref/templates/builtins/#now

b Month, textual, 3 letters, lowercase.

However the French translation for the month of August is currently "aout" (4 chars).

This cause an url pattern like (?P<month>\w\w\w) to throw a NoReverseMatch in French.

The attached patch fix the issue.

Attachments (2)

fix-french-translation-3-letters-august.diff (353 bytes) - added by Djoume Salvetti 7 years ago.
french translation update
10773.diff (510 bytes) - added by Karen Tracey 7 years ago.

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by Djoume Salvetti

french translation update

comment:1 Changed 7 years ago by Julien Phalip

milestone: 1.1
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [10508]) Fixed #10773 -- Small fix to the French translation. Thanks, djoume.

comment:3 Changed 7 years ago by Malcolm Tredinnick

(In [10509]) [1.0.X] Fixed #10773 -- Small fix to the French translation. Thanks, djoume.

Backport of r10508 from trunk.

comment:4 Changed 7 years ago by Stephane Raimbault

Component: UncategorizedTranslations
Resolution: fixed
Status: closedreopened

mtredinnick,

You didn't apply the right fix, you've mix up 'aug' and 'August'!

comment:5 Changed 7 years ago by Ahmed Zouari

Resolution: fixed
Status: reopenedclosed

Please reverse change 10509
and
apply patch

comment:6 Changed 7 years ago by Alex Gaynor

Resolution: fixed
Status: closedreopened

This has not been fixed.

comment:7 Changed 7 years ago by Karen Tracey

Added a patch that restores the full "August" translation and uses 3-char abbr. for both "aug" and "Aug.". Not sure whether that last one is correct though since it wasn't part of the original request -- can anyone with better knowledge of French than me either confirm or explain why you wouldn't want to consistently abbreviate it?

comment:8 in reply to:  7 Changed 7 years ago by Julien Phalip

Replying to kmtracey:

Added a patch that restores the full "August" translation and uses 3-char abbr. for both "aug" and "Aug.". Not sure whether that last one is correct though since it wasn't part of the original request -- can anyone with better knowledge of French than me either confirm or explain why you wouldn't want to consistently abbreviate it?

Karen, your patch is correct except for msgid "Aug." which shouldn't be changed (it should remain "août"). This is because August in French only has 4 letters and so it doesn't need to be abbreviated (since "Aug." also has 4 characters).

However, I've noticed something strange. Why is April not abbreviated? There is no msgid "Apr."...

Changed 7 years ago by Karen Tracey

Attachment: 10773.diff added

comment:9 Changed 7 years ago by Karen Tracey

OK, thanks, I fixed the patch to not mess with the "Aug." translation. Based on where the string comes from, actually, I see it isn't a 3-letter abbreviation, really, it's just the Associated Press style name. Apparently AP abbreviates only months with more than 5 chars in their name, so March, April, May, June, and July don't get abbreviated, plus September gets a 4-letter abbr. instead of 3 like the rest that get abbreviated.

comment:10 Changed 7 years ago by Malcolm Tredinnick

Resolution: fixed
Status: reopenedclosed

(In [10595]) Fixed #10773 -- Fixed some damage I did to the French in r10508.

Patch from Karen Tracey.

comment:11 Changed 7 years ago by Malcolm Tredinnick

(In [10596]) [1.0.X] Fixed #10773 -- Fixed some damage I did to the French in r10509.

Patch from Karen Tracey.

Backport of r10595 from trunk.

comment:12 in reply to:  9 Changed 7 years ago by Stephane Raimbault

Replying to kmtracey:

The problem brought up by julien and kmtracey is already reported by #9988.

comment:13 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top