#10773 closed (fixed)
3 letters french translation of August use 4 chars
| Reported by: | Djoume Salvetti | Owned by: | nobody |
|---|---|---|---|
| Component: | Translations | Version: | 1.0 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
According to the documentation:
http://docs.djangoproject.com/en/dev/ref/templates/builtins/#now
b Month, textual, 3 letters, lowercase.
However the French translation for the month of August is currently "aout" (4 chars).
This cause an url pattern like (?P<month>\w\w\w) to throw a NoReverseMatch in French.
The attached patch fix the issue.
Attachments (2)
Change History (15)
by , 16 years ago
| Attachment: | fix-french-translation-3-letters-august.diff added |
|---|
comment:1 by , 16 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 16 years ago
comment:4 by , 16 years ago
| Component: | Uncategorized → Translations |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
mtredinnick,
You didn't apply the right fix, you've mix up 'aug' and 'August'!
comment:5 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Please reverse change 10509
and
apply patch
follow-up: 8 comment:7 by , 16 years ago
Added a patch that restores the full "August" translation and uses 3-char abbr. for both "aug" and "Aug.". Not sure whether that last one is correct though since it wasn't part of the original request -- can anyone with better knowledge of French than me either confirm or explain why you wouldn't want to consistently abbreviate it?
comment:8 by , 16 years ago
Replying to kmtracey:
Added a patch that restores the full "August" translation and uses 3-char abbr. for both "aug" and "Aug.". Not sure whether that last one is correct though since it wasn't part of the original request -- can anyone with better knowledge of French than me either confirm or explain why you wouldn't want to consistently abbreviate it?
Karen, your patch is correct except for msgid "Aug." which shouldn't be changed (it should remain "août"). This is because August in French only has 4 letters and so it doesn't need to be abbreviated (since "Aug." also has 4 characters).
However, I've noticed something strange. Why is April not abbreviated? There is no msgid "Apr."...
by , 16 years ago
| Attachment: | 10773.diff added |
|---|
follow-up: 12 comment:9 by , 16 years ago
OK, thanks, I fixed the patch to not mess with the "Aug." translation. Based on where the string comes from, actually, I see it isn't a 3-letter abbreviation, really, it's just the Associated Press style name. Apparently AP abbreviates only months with more than 5 chars in their name, so March, April, May, June, and July don't get abbreviated, plus September gets a 4-letter abbr. instead of 3 like the rest that get abbreviated.
comment:10 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
french translation update