BaseInlineFormSet does not respect commit=False in save for new objects after r10190

[Koen Biermans <koen.biermans@…>]

The save_new method on BaseInlineFormSet does not respect the commit bit passed to it (it saves the object even if commit=False). This method was added in r10190.

This means that if there are required fields that the forms on the inlineformset do not contain, you get an error, even if you use commit=False to add the required information to the new objects yourself.

Possible fix: do not do obj.save() if commit is False (line 549 in django/forms/models.py).

[Koen Biermans <koen.biermans@…>]

fix and test for baseinlineformset save not respecting commit=False

[Koen Biermans <koen.biermans@…>]

new try, replace messed up diff

[jkocherhans]

Thanks for adding a test case. I'll put this on my review list for 1.1.

[Jacob]

(In [10706]) Fixed #10750: respect comment=False in inline formsets. Thanks, Koen Biermans.

[Jacob]

Milestone 1.1 deleted