Syntax error and bug in db/backends/oracle/creation.py
|Reported by:||CanariX||Owned by:||nobody|
|Component:||Database layer (models, ORM)||Version:||1.0|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Playing with the django tests on an Oracle DB, I've found 2 bugs in the db/backends/oracle/creation.py file :
- line 110, the line settings.DATABASE_NAME = TEST_DATABASE_NAME is missing. Without this line, Django could use the production DB instead of the test one (can be quite annoying).
This mod also impacts the mods on some other lines because of the "remember" dict.
- line 247, there's 2 typos : it should be "def _test_database_user(self, settings):" instead of "def _test_database_user(self, ettings):" and DATABASE_USER instead of DATABASE_NAME
I saw the problem in the 1.0.2 version, but the SVN has the same errors.
I attached a patch for the 1.0.2 version
Change History (11)
comment:1 Changed 8 years ago by
|Patch needs improvement:||unset|
|Triage Stage:||Unreviewed → Accepted|