Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#1071 closed task (wontfix)

[patch] generic views (object_list/object_detail/date) should take login_required as a parameter

Reported by: Ian@… Owned by: Jacob
Component: Generic views Version: master
Severity: major Keywords:
Cc: root.lastnode@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

as some non-updated pages might require a login.

regards
Ian

Attachments (3)

patch-django-views-generic_login-required_#1071 (7.0 KB) - added by trbs 10 years ago.
patch-django-views-generic_login-required_#1071_2 (7.2 KB) - added by root.lastnode@… 10 years ago.
update to revision 3490
patch-django-views-generic_login-required_#1071_2.diff (7.2 KB) - added by root.lastnode@… 10 years ago.
update to revision 3490 now with .diff ending as recommended in contributing documentation

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by anonymous

Component: Generic viewsDatabase wrapper
milestone: Version 0.91
Owner: changed from Jacob to Adrian Holovaty
priority: normallowest
Severity: normalmajor
Type: defecttask

comment:2 Changed 10 years ago by trbs

Cc: root.lastnode@… added
Summary: generic views (object_list/object_detail/date) should take login_required as a parameter[patch] generic views (object_list/object_detail/date) should take login_required as a parameter

i also wanted to project generic views like object_list/object_detail and alikes.

created a patch to the django.views.generic sources to allow login_required parameter
to be set on all but django.views.generic.simple generics

-- trbs

comment:3 Changed 10 years ago by trbs

Component: Database wrapperGeneric views
Owner: changed from Adrian Holovaty to Jacob

isn't this part of 'generic views' component ?

sounds more likely to me, then 'database wrapper'

comment:4 Changed 10 years ago by anonymous

milestone: Version 0.91Version 0.92
priority: lowestnormal
Version: SVN

Changed 10 years ago by root.lastnode@…

update to revision 3490

comment:5 Changed 10 years ago by root.lastnode@…

priority: normalhigh

set priority to: high

IMHO, it seems logical to get this patch in as soon as possible.
i know that there are several projects in django regarding a move
advanced authentication framework. But in neither GenericAuthorization
or RowLevelPermissions i find references on how this will change Authentication
of views.

As long as views deal directly with there own authentication, i hope this patch
can be adopted for completeness sake. So users can require login on all generic views
django provides per default.

When another system takes over, i guess all the login_required parameters will be stripped
from generic views, so including a few more now to deal with authentication on
list_detail and alike generic views doesn't seem like a problem to me.

Ofcourse i'll leave the definition of 'problem' to the Django developers :)

Changed 10 years ago by root.lastnode@…

update to revision 3490 now with .diff ending as recommended in contributing documentation

comment:6 Changed 10 years ago by Jacob

priority: highlow

comment:7 Changed 10 years ago by Adrian Holovaty

Resolution: wontfix
Status: newclosed

I'm marking this as a wontfix now, because as of [3554], URLconfs can take any callable. That means you can pass login_required(my_generic_view) directly to the URLconf.

comment:8 Changed 10 years ago by Adrian Holovaty

milestone: Version 0.92

Milestone Version 0.92 deleted

Note: See TracTickets for help on using tickets.
Back to Top