Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#10694 closed (fixed)

user_change_password in UserAdmin should lookup change permission

Reported by: james Turnbull Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When subclassing UserAdmin the internal user_change_password view has a hardcoded "auth.change_user" permission check.

That requires the user to have edit permissions for the user model aswell as the subclass.

It should instead use the local has_change_permission check, which is neater anyway. Attached patch fixes this.

Attachments (1)

user_change_password_permissions.diff (574 bytes) - added by james Turnbull 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by james Turnbull

comment:1 Changed 7 years ago by Jacob

milestone: 1.1
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Alex Gaynor

Triage Stage: AcceptedReady for checkin

comment:3 Changed 7 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [10591]) Fixed #10694: correctly check permissions in the change password admin. Thanks, jturnbull.

comment:4 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top