Opened 6 years ago

Closed 6 years ago

#10676 closed (fixed)

new test methodology (db rollback rather than reset) causes error when parameters passed to transaction methods

Reported by: seanl Owned by: kmtracey
Component: Testing framework Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Basically the assignment of 'nop' to the various transaction-management methods has a problem in the case of 'enter_transaction_management' which can accept a 'managed' argument whereas 'nop' only accepts 'x'. The easy solution is to make 'nop' accept any args/kwargs (see attached patch).

Attachments (1)

10676-testcase-nop-accepts-any-args.diff (417 bytes) - added by seanl 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by seanl

comment:1 Changed 6 years ago by kmtracey

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to kmtracey
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.0 to SVN

Right. Thanks for pointing that out. I'll fix it.

comment:2 Changed 6 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10248]) Fixed #10676 -- Make transaction nop routine used during testing accept any args/kwargs it might be called with. Thanks seanl.

Note: See TracTickets for help on using tickets.
Back to Top