Test failure in regressiontests.templates.tests.Templates

[Glenn Maynard]

Straightforward test failure in r10222 with 2.5:

======================================================================
ERROR: test_templates (regressiontests.templates.tests.Templates)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/glenn/django/tests/regressiontests/templates/tests.py", line 212, in test_templates
    exc_type, exc_value, exc_tb = sys.exc_info()
NameError: global name 'sys' is not defined

[Alex Gaynor]

This runs fine for me under 2.5. Can you provide some more details?

[Glenn Maynard]

                except Exception:
                    exc_type, exc_value, exc_tb = sys.exc_info()
                    if exc_type != result:
                        tb = '\n'.join(traceback.format_exception(exc_type, exc_value, exc_tb))
                        failures.append("Template test (TEMPLATE_STRING_IF_INVALID='%s'): %s -- FAILED. Got %s, exception: %s\n%s" % (invalid_str, name, exc_type, exc_value, tb))
                    continue

sys.exc_info is being used, and sys isn't being imported. Can you check:

• Is this code path being reached for you? (If not, something about this test has a nondeterministic code path, which is probably a bug.)
• If so, then where is the sys module being imported for you?

[Alex Gaynor]

No it doesn't hit that code path for me, but sys is clearly used there and not imported so we should just add the import.

[Gary Wilson]

(In [10244]) Fixed #10667 -- Added missing sys import.

[Gary Wilson]

(In [10245]) [1.0.X]: Fixed #10667 -- Added missing sys import.

Backport of r10244 from trunk.

[Jacob]

Milestone 1.1 deleted