#10651 closed (fixed)
auth app add user page causes javascript error due to admin change_form assuming presence of adminform object
| Reported by: | Sean Legassick | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The contrib.auth add user page (add_form.html) causes a javascript error. This is due to the extended change_form.html inserting the following because of a missing adminform object in the context:
<script type="text/javascript">document.getElementById("").focus();</script>
The attached patch fixes this by having change_form.html check for presence of adminform and skipping the above line if it isn't present (which is correct because add_form.html has a hard-coded version of the same JS to set focus to the username field).
Attachments (2)
Change History (8)
by , 16 years ago
| Attachment: | gltailpatch added |
|---|
by , 16 years ago
| Attachment: | 10651-change-form-checks-for-adminform-object.diff added |
|---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 16 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:4 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 16 years ago
Note:
See TracTickets
for help on using tickets.
Please ignore first patch labelled 'gltailpatch' - operator error.