#1065 closed enhancement (fixed)
Add a template tag that allows for partial caching of templates
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Template system | Version: | dev |
Severity: | normal | Keywords: | sprintsept14 feature |
Cc: | jshaffer2112@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
This is a nice idea. Just wanted to make sure this one was captured.
Attachments (5)
Change History (20)
comment:1 by , 18 years ago
Has patch: | set |
---|---|
Needs documentation: | set |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 years ago
Needs documentation: | unset |
---|---|
Needs tests: | set |
comment:3 by , 17 years ago
I figured the name 'fragment_caching' was a bit redundant for the template library since all caching within templates will be fragment caching (but maybe it's just me).
comment:4 by , 17 years ago
Cc: | added |
---|---|
Needs tests: | unset |
comment:5 by , 17 years ago
Keywords: | sprintsept14 added |
---|---|
Triage Stage: | Accepted → Ready for checkin |
comment:6 by , 17 years ago
Keywords: | feature added |
---|
comment:7 by , 17 years ago
Version: | → SVN |
---|
comment:8 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:9 by , 17 years ago
Unusable, seem to give Unicode errors as soon as you have to do with real non-ascii characters. Was this thoroughly tested?
comment:10 by , 17 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Triage Stage: | Ready for checkin → Accepted |
Can you please give an example of how to make it fail?
comment:11 by , 17 years ago
Hum... for the moment it seems the problem is magically gone. But I swear nothing worked after adding it and it gave Unicode errors :/
comment:12 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Well, if/when you can repeat the problem, please reopen the ticket (don't just add a comment), with details. A small example, plus details of what cache you are using will be required so that we can repeat the problem.
comment:13 by , 17 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Somehow the idea of having cache time spread all over the place seems a bit cluttering especially if you use the tag more frequently throughout templates. Having the timeout in a single variable is helpful.
The patch allows the timeout to be a template variable and also adds some extra tests.
comment:14 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
ZZ, this is new functionality, so belongs in a new ticket. Please open a new ticket for this new functionality and attach your patch to that :)
Moving Ian Maurer's post in the group discussion to this ticket since it's a great patch. Probably needs some documentation and then it's good to go.
Approving due to Adrian's comment in the discussion.
For instance...