Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#10643 closed (fixed)

formtools do not handle forms with empty_permitted

Reported by: Nils Fredrik Gjerull Owned by:
Component: contrib.formtools Version: master
Severity: Keywords: empty_permitted
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.contrib.formtools do not handle forms with empty_permitted set to true correctly. It tries to validate the form data even if the form has not changed.

Attachments (5)

formtools_utils.diff (676 bytes) - added by Nils Fredrik Gjerull 8 years ago.
10643.diff (1.7 KB) - added by Andy Durdin 8 years ago.
Updated patch to add tests
10643.2.diff (1.7 KB) - added by Andy Durdin 8 years ago.
Better names in patch
security_hash.diff (2.1 KB) - added by Ulrich Petri 8 years ago.
Cleaned up testcase
security_hash.2.diff (2.1 KB) - added by Ulrich Petri 8 years ago.
Fixed stupid diff-of-diff mistake

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by Nils Fredrik Gjerull

Attachment: formtools_utils.diff added

comment:1 Changed 8 years ago by Jacob

milestone: 1.1
Needs documentation: set
Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by Andy Durdin

Owner: changed from nobody to Andy Durdin
Status: newassigned

comment:3 Changed 8 years ago by Andy Durdin

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Updated patch to add tests.

Changed 8 years ago by Andy Durdin

Attachment: 10643.diff added

Updated patch to add tests

comment:4 Changed 8 years ago by Andy Durdin

Owner: Andy Durdin deleted
Status: assignednew

comment:5 Changed 8 years ago by Jacob

A better name for the test case is all that's standing between this and committing.

Changed 8 years ago by Andy Durdin

Attachment: 10643.2.diff added

Better names in patch

Changed 8 years ago by Ulrich Petri

Attachment: security_hash.diff added

Cleaned up testcase

Changed 8 years ago by Ulrich Petri

Attachment: security_hash.2.diff added

Fixed stupid diff-of-diff mistake

comment:6 Changed 8 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [10753]) Fixed #10643: fixed the formtools security hash to handle allowed empty forms or forms without changed data.

comment:7 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top