Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10643 closed (fixed)

formtools do not handle forms with empty_permitted

Reported by: nfg Owned by:
Component: contrib.formtools Version: master
Severity: Keywords: empty_permitted
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.contrib.formtools do not handle forms with empty_permitted set to true correctly. It tries to validate the form data even if the form has not changed.

Attachments (5)

formtools_utils.diff (676 bytes) - added by nfg 5 years ago.
10643.diff (1.7 KB) - added by adurdin 5 years ago.
Updated patch to add tests
10643.2.diff (1.7 KB) - added by adurdin 5 years ago.
Better names in patch
security_hash.diff (2.1 KB) - added by UloPe 5 years ago.
Cleaned up testcase
security_hash.2.diff (2.1 KB) - added by UloPe 5 years ago.
Fixed stupid diff-of-diff mistake

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by nfg

comment:1 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Needs documentation set
  • Needs tests set
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by adurdin

  • Owner changed from nobody to adurdin
  • Status changed from new to assigned

comment:3 Changed 5 years ago by adurdin

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Updated patch to add tests.

Changed 5 years ago by adurdin

Updated patch to add tests

comment:4 Changed 5 years ago by adurdin

  • Owner adurdin deleted
  • Status changed from assigned to new

comment:5 Changed 5 years ago by jacob

A better name for the test case is all that's standing between this and committing.

Changed 5 years ago by adurdin

Better names in patch

Changed 5 years ago by UloPe

Cleaned up testcase

Changed 5 years ago by UloPe

Fixed stupid diff-of-diff mistake

comment:6 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10753]) Fixed #10643: fixed the formtools security hash to handle allowed empty forms or forms without changed data.

comment:7 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.