Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10597 closed (fixed)

Admin Actions "Select all" checkbox doesn't work in IE6/7

Reported by: kyle.fox@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: javascript, admin, admin actions, IE
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The select all checkbox doesn't work in Internet Explorer 6 or 7.

This is because the event handler being attached is the 'change' event ('onchange' in MSIE), which apparently doesn't work for checkboxes. There was also an issue with passing {{ this.checked }} in the anonymous event handler.

This patch fixed the 'onchange' issue by instead using the 'click' event, which seems to offer the same functionality as the 'click' event (including keyboard manipulation).

Attachments (1)

10597.diff (640 bytes) - added by kyle.fox@… 5 years ago.
Patch for #10597 - Fixed Admin Actions checkbox in IE6/7

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by kyle.fox@…

Patch for #10597 - Fixed Admin Actions checkbox in IE6/7

comment:1 Changed 5 years ago by brosner

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [10135]) Fixed #10597 -- select all checkbox on admin changelist now works under IE 6 and 7. Thanks kyle.fox.

comment:3 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.