Code

Opened 5 years ago

Closed 4 years ago

#10457 closed (fixed)

date_based view archive_today should update kwargs for month/day_format

Reported by: Dirk Datzert <dummy@…> Owned by: nobody
Component: Generic views Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,

I started using date_based generic views today. I call archive_day and archive_today with the same dictionary in the urls.py with a special month_format and/or day_format setting in the dictionary.

As archive_today uses a special month_format/day_format by default and calls archive_day it should set the correct month_format/day_format if a caller sets somethingelse.

Regards,
Dirk

Attachments (1)

date_based_kwargs.diff (466 bytes) - added by Dirk Datzert <dummy@…> 5 years ago.
archive_today always correct kwargs patch

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Dirk Datzert <dummy@…>

archive_today always correct kwargs patch

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 5 years ago by thejaswi_puthraya

  • Component changed from Uncategorized to Generic views
  • Has patch set

comment:3 Changed 4 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

Function-based generic views were deprecated by the introduction of class-based views in [14254]. Class-based views should solve this problem.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.