Code

Opened 5 years ago

Closed 5 years ago

#10440 closed (wontfix)

attribute vs. method call

Reported by: rihad Owned by: nobody
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A quick suggestion:

Taken from http://www.djangobook.com/en/2.0/chapter07/

>>> f = ContactForm({'subject': 'Hello', 'email': 'adrian@example.com', 'message': 'Nice site!'})
"""
>>> f.is_bound
True
>>> f.is_valid()
True
"""

Why not hide internal details of the implementation by making all such calls either attributes/properties (cooler IMHO) or method calls?

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

For a start, because backwards-compatibility is requirement.

Methods tend to indicate that there's some non-trivial computation going on the background.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.