#10400 closed (fixed)
File upload documentation should emphasize the need to add multipart/form-data
| Reported by: | Claude Paroz | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.0 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Even if it is explained in the request-response documentation (http://docs.djangoproject.com/en/dev/ref/request-response/#django.http.HttpRequest.FILES), I suggest to repeat the need to add multipart/form-data to the form tag in the 'File Upload' documentation. Following a patch which simply repeat the request-reponse note about it in the topics/http/file-uploads.txt doc file.
Attachments (3)
Change History (9)
by , 16 years ago
| Attachment: | fileupload.diff added |
|---|
comment:1 by , 16 years ago
| Summary: | File upload documentattion should emphasize the need to add multipart/form-data → File upload documentation should emphasize the need to add multipart/form-data |
|---|
comment:2 by , 16 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
by , 16 years ago
| Attachment: | fileupload.2.diff added |
|---|
comment:3 by , 16 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:4 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 15 years ago
comment:6 by , 15 years ago
Note I didn't used the metadata target version of the patch because it seems to reference model fields, yet this doc is strictly about forms, so shouldn't the pointers reference form fields? Feel free to open another ticket to get the references in, but either point them to form fields or explain why they should go to ~django.db.models.FileField, e.g. ... that doesn't look right to me when the code examples are just using form fields.
slightly modified from original patch