#10397 closed (fixed)
Add support for DATABASE_SUPPORTS_TRANSACTIONS to django.contrib.gis.tests.run_tests
| Reported by: | Malcolm Tredinnick | Owned by: | jbronn |
|---|---|---|---|
| Component: | GIS | Version: | 1.0 |
| Severity: | Keywords: | create_spatial_db gis tests | |
| Cc: | Almad | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
After r9756, it's no longer possible to run a full test suite for a set of applications (a Django "project") when using the gis test runner. This is because we need to set up DATABASE_SUPPORTS_TRANSACTIONS, which is used by, at a minimum, the auth tests.
This seems like the tip of the iceberg in some ways, though. There's already a handy function to help with this, but it's part of django.db.backends.creation.BaseDatabaseCreation, which django.contrib.gis doesn't use at all for creating test databases. I suspect the solution is to break up the BaseDatabaseCreation class into basic stuff and test stuff so that gis can use the subclass the latter.
Attachments (1)
Change History (6)
comment:1 by , 16 years ago
| Cc: | added |
|---|
comment:2 by , 16 years ago
| Description: | modified (diff) |
|---|---|
| Has patch: | set |
| Keywords: | create_spatial_db gis tests added |
| milestone: | → 1.1 |
| Owner: | changed from to |
| Status: | new → assigned |
by , 16 years ago
| Attachment: | create_spatial_db_support_transactions.diff added |
|---|
comment:3 by , 16 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
This looks good to me. Commit it, already. :-)
comment:4 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
It's also used by any unit test that subclasses
django.test.TestCase. The attached patch adds this setting; MySQL and Oracle shouldn't be affected because it's only PostGIS that really uses something different than the defaultconnection.creation.create_test_db.