Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10387 closed (fixed)

code duplication in django.utils.cache

Reported by: travis@… Owned by: nobody
Component: Core (Cache system) Version: master
Severity: Keywords: bikeshed
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Completely trivial commit, but while exploring the caching mechanisms of Django, I noticed some code duplication. The patch (attached) is viewable on Gist as well.

Attachments (2)

_generate_cache_header_key.patch (1.8 KB) - added by Travis Swicegood <travis@…> 5 years ago.
10387.diff (1.6 KB) - added by mboersma 5 years ago.
Same patch, renamed with our preferred .diff extension

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Travis Swicegood <travis@…>

comment:1 Changed 5 years ago by anonymous

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by mboersma

Same patch, renamed with our preferred .diff extension

comment:2 Changed 5 years ago by mboersma

  • Triage Stage changed from Accepted to Ready for checkin

comment:3 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10223]) Fixed #10387: removed some code duplication in django.utils.cache. Thanks, Travis Swicegood.

comment:4 Changed 5 years ago by jacob

(In [10290]) [1.0.X] Fixed #10387: removed some code duplication in django.utils.cache. Thanks, Travis Swicegood.

Backport of r10223 from trunk.

comment:5 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.