[patch] Generic view `list_detail` pagination should be one-indexed in URL
Reported by: |
Tom Tobin <korpios@…> |
Owned by: |
Jacob |
Component:
|
Generic views
|
Version:
|
|
Severity:
|
normal
|
Keywords:
|
|
Cc:
|
|
Triage Stage:
|
Unreviewed
|
Has patch:
|
yes
|
Needs documentation:
|
no
|
Needs tests:
|
no
|
Patch needs improvement:
|
no
|
Easy pickings:
|
no
|
UI/UX:
|
no
|
While having the ObjectPaginator
class be zero-indexed internally makes sense, having the GET variable for the current page number also be zero-indexed doesn't; one-indexed numbers are all a user should have to understand, and it's doubly confusing to be visiting a page claiming to be "3 of 4" yet have ?page=2
in the URL.
The attached patch fixes the list_detail
generic view to be one-indexed, while leaving ObjectPaginator
alone (i.e., zero-indexed).
Implements one-indexed
list_detail
generic view