Opened 7 years ago

Closed 6 years ago

Last modified 4 years ago

#10326 closed (fixed)

Allow handler500, handler404 to be callables

Reported by: miracle2k Owned by: nobody
Component: Core (Other) Version: 1.0
Severity: Keywords: handler404 handler500 callable
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently, those are expected to be strings pointing to the view to use. A number of times now I've stumbled over this and thought it would be neat if I could just specify a callable, especially if the view is not much more than redirect to render_to_response.

Attachments (2)

handlerXXX_callable.diff (2.0 KB) - added by dcwatson 6 years ago.
Patch and doc updates
handlerXXX_callable.2.diff (4.4 KB) - added by adurdin 6 years ago.
Updated patch against r10682; updated version in docs to 1.2; added tests.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by dcwatson

Patch and doc updates

comment:2 Changed 6 years ago by dcwatson

  • Has patch set
  • Keywords handler404 handler500 callable added

comment:3 Changed 6 years ago by ericholscher

  • Needs tests set

This patch needs tests. If someone could do that at some point, that'd be great, otherwise I'll do it.

comment:4 Changed 6 years ago by jacob

  • milestone changed from 1.1 to 1.2

Changed 6 years ago by adurdin

Updated patch against r10682; updated version in docs to 1.2; added tests.

comment:5 Changed 6 years ago by adurdin

  • Needs tests unset
  • Triage Stage changed from Accepted to Ready for checkin

Trac patch viewer is failing again, but the patch does download and apply correctly.

comment:6 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [11854]) Fixed #10326: handler500 and handler404 may now be callables. Thanks, dcwatson, adurdin.

comment:7 Changed 4 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top