Opened 10 years ago

Closed 9 years ago

Last modified 8 years ago

#10323 closed (fixed)

Dont force admin media serving with runserver management command.

Reported by: Vadim Fint Owned by: Jannis Leidel
Component: runserver Version: 1.0
Severity: Keywords:
Cc: treborhudson@…, Jannis Leidel Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Dont know why, but runserver manage command starts explicity serving of admin media. For proper encapsulation (contrib vs core) and ability to drop out admin contrib from django installation - here is simple patch wich allows to disable admin media serving via --disable-admin-media.

Also right now runserver will die if you remove contrib/admin.

Attachments (1)

mocksoul_dont_force_admin_media_serving.patch (1.7 KB) - added by Vadim Fint 10 years ago.

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by Vadim Fint

comment:1 Changed 10 years ago by Vadim Fint

of course, all django tests pass :).

comment:2 Changed 10 years ago by Eric Holscher

Triage Stage: UnreviewedAccepted

Seems legitimate that runserver shouldn't depend on admin/admin media.

comment:3 Changed 10 years ago by Rob Hudson <treborhudson@…>

Cc: treborhudson@… added

I'd actually like to see a discussion of how reusable Django apps can specify their own media and treat contrib.admin as just another reusable app. I know a number of reusable apps that would like some hook into serving media via runserver without resorting to hacks or "copy files to your media folder" instructions.

comment:4 Changed 10 years ago by Rob Hudson <treborhudson@…>

comment:5 Changed 10 years ago by Jannis Leidel

Cc: Jannis Leidel added

comment:6 Changed 9 years ago by Jannis Leidel

milestone: 1.3
Owner: changed from nobody to Jannis Leidel
Status: newassigned

Assigning this myself since we have that feature (--nostatic) in the new staticfiles app, the successor to the AdminMediaHandler. Going to close this with a few other doc tweaks.

comment:7 Changed 9 years ago by Jannis Leidel

Resolution: fixed
Status: assignedclosed

Calling this fixed in trunk since an option for the runserver command has been added in r14533 and r14553.

comment:8 Changed 8 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top