#10323 closed (fixed)
Dont force admin media serving with runserver management command.
| Reported by: | Vadim Fint | Owned by: | Jannis Leidel |
|---|---|---|---|
| Component: | django-admin.py runserver | Version: | 1.0 |
| Severity: | Keywords: | ||
| Cc: | treborhudson@…, Jannis Leidel | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Dont know why, but runserver manage command starts explicity serving of admin media. For proper encapsulation (contrib vs core) and ability to drop out admin contrib from django installation - here is simple patch wich allows to disable admin media serving via --disable-admin-media.
Also right now runserver will die if you remove contrib/admin.
Attachments (1)
Change History (9)
by , 15 years ago
| Attachment: | mocksoul_dont_force_admin_media_serving.patch added |
|---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Seems legitimate that runserver shouldn't depend on admin/admin media.
comment:3 by , 15 years ago
| Cc: | added |
|---|
I'd actually like to see a discussion of how reusable Django apps can specify their own media and treat contrib.admin as just another reusable app. I know a number of reusable apps that would like some hook into serving media via runserver without resorting to hacks or "copy files to your media folder" instructions.
comment:5 by , 15 years ago
| Cc: | added |
|---|
comment:6 by , 13 years ago
| milestone: | → 1.3 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
Assigning this myself since we have that feature (--nostatic) in the new staticfiles app, the successor to the AdminMediaHandler. Going to close this with a few other doc tweaks.
comment:7 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
of course, all django tests pass :).