makemessages.py SyntaxErrors are hard to track because they don't say which template or file it happened in

[Peter Bengtsson]

I ran django-admin.py makemessages -l sv and it turns out that I had forgotten the 'end' on {% endblocktrans %} so it threw this error:

SyntaxError: Translation blocks must not include other block tags: blocktrans

If you have many files with blocktrans in them it's hard to know where you've make the syntax error.
I patched makemessages.py to also include the filename into error message. Now the error message looks like this instead:

SyntaxError: Translation blocks must not include other block tags: blocktrans (file: ./search/templates/500.html)

[Peter Bengtsson]

belongs in django/core/management/commands/

[Peter Bengtsson]

Noticed that when you download the .diff file or when you try to view it here on Trac it shows as just one line. Weird.

[Ramiro Morales]

Replying to peterbe:

Noticed that when you download the .diff file or when you try to view it here on Trac it shows as just one line. Weird.

The patch contents looks mostly ok when you download it. Please generate it from the root of the django tree so the .diff header contains the django/core/management/commands/makemessages.py path. Also, specify the -u (unified) to diff, this will solve the Trac display problem.

This is described at ​http://docs.djangoproject.com/en/dev/internals/contributing/#patch-style.

Thanks for you contribution!

[Andrew Badr]

Going to duplicate the original patch

[Andrew Badr]

Same patch, corrected format

[Malcolm Tredinnick]

(In [10538]) Fixed #10234 -- Improved error message when internationalizing templates.

Patch from peterbe and Andrew Badr.

[Jacob]

Milestone 1.1 deleted