Code

Opened 5 years ago

Closed 5 years ago

#10230 closed (duplicate)

admin_order_field on callable field always pointing to ascending sort

Reported by: chris.czub@… Owned by: nobody
Component: contrib.admin Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When I create a callable field in order to grab a field from a foreign key'd model and then try to set admin_order_field on that callable field, the template always points to "?ot=asc" in the URL, no matter if I am currently sorting ascending or descending. This means that I cannot by using the HTML controls switch to a descending sort on this field. If I change the url to "?ot=desc", it properly sorts in descending order.

Code in admin:

class OrderAdmin(admin.ModelAdmin):

list_display = ('item', 'user', 'date', 'period', 'get_item_price')
search_fields = item__name?
date_hierarchy = 'date'
list_filter = date?

def get_item_price(self, obj):

return "$%s"%(obj.item.price)

get_item_price.short_description = "Price"
get_item_price.admin_order_field = "itemprice"

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by Chris Czub <chris.czub@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Example code:

class OrderAdmin(admin.ModelAdmin):
    list_display = ('item', 'user', 'date', 'period', 'get_item_price')
    search_fields = ['item__name']
    date_hierarchy = 'date'
    list_filter = ['date']

    def get_item_price(self, obj):
        return "$%s"%(obj.item.price)
    get_item_price.short_description = "Price"
    get_item_price.admin_order_field = "item__price"

comment:2 Changed 5 years ago by Chris Czub <chris.czub@…>

  • Resolution set to duplicate
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.