Opened 16 years ago
Closed 12 years ago
#10214 closed New feature (duplicate)
Add 'internal' option to SEND_BROKEN_LINK_EMAILS
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Core (Other) | Version: | 1.0 |
Severity: | Normal | Keywords: | |
Cc: | Will Boyce | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I don't really care if people are linking to my site incorrectly, there's not much I can do about that.
I created the attached patch to make SEND_BROKEN_LINK_EMAILS accept 'internal' as a value, resulting only in an email if the referring domain is the same as the site request domain.
Attachments (2)
Change History (11)
by , 16 years ago
Attachment: | SBLE_internal.diff added |
---|
comment:1 by , 16 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
I don't much like this setting change -- True/False/"internal" has that code smell to me -- but I wonder why the '?' in referrer
bit is there to begin with. Perhaps we should just ignore all external broken links?
comment:2 by , 16 years ago
-1 on automatically ignoring external broken links. There's a lot of valuable intelligence to be gleaned from that: handling common mistakes (e.g. people not URL-encoding things correctly), spotting when URL accidentally moved or was renamed. Allowing it to be configurable is probably reasonable. Removing the facility which is actually useful today would not be so cool.
comment:3 by , 14 years ago
Component: | Uncategorized → Core framework |
---|
comment:4 by , 14 years ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
Severity: | → Normal |
Type: | → New feature |
comment:5 by , 13 years ago
Easy pickings: | unset |
---|---|
Needs documentation: | set |
Needs tests: | set |
Triage Stage: | Design decision needed → Accepted |
UI/UX: | unset |
We could change SEND_BROKEN_LINK_EMAILS
to accept 'none'
, 'internal'
and 'all'
as valid values.
True
and False
would be interpreted as 'all'
and 'none'
for backwards compatibility.
The change would have to be explained in the release notes.
by , 13 years ago
Attachment: | SBLE_internal_81e644e.diff added |
---|
comment:6 by , 13 years ago
Cc: | added |
---|---|
Needs documentation: | unset |
Needs tests: | unset |
Patch needs improvement: | unset |
Updated patch to meet aaugustin's notes and include documentation/tests.
comment:7 by , 13 years ago
Needs documentation: | set |
---|---|
Owner: | changed from | to
At first sight the patch looks good. It just needs an explanation of the difference between "all" and "internal" in error-reporting.txt
, and a paragraph in the release notes.
comment:8 by , 13 years ago
Owner: | changed from | to
---|
comment:9 by , 12 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Since my last comment, I split out this feature in its own middleware, and I deprecated SEND_BROKEN_LINK_EMAILS.
#20099 will make it easier to customize the behavior to your liking, by subclassing this middleware.
SBLE_internal