Opened 10 years ago

Closed 6 years ago

#10214 closed New feature (duplicate)

Add 'internal' option to SEND_BROKEN_LINK_EMAILS

Reported by: mail@… Owned by: nobody
Component: Core (Other) Version: 1.0
Severity: Normal Keywords:
Cc: Will Boyce Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


I don't really care if people are linking to my site incorrectly, there's not much I can do about that.

I created the attached patch to make SEND_BROKEN_LINK_EMAILS accept 'internal' as a value, resulting only in an email if the referring domain is the same as the site request domain.

Attachments (2)

SBLE_internal.diff (1013 bytes) - added by mail@… 10 years ago.
SBLE_internal_81e644e.diff (8.9 KB) - added by Will Boyce 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by mail@…

Attachment: SBLE_internal.diff added


comment:1 Changed 10 years ago by Jacob

Triage Stage: UnreviewedDesign decision needed

I don't much like this setting change -- True/False/"internal" has that code smell to me -- but I wonder why the '?' in referrer bit is there to begin with. Perhaps we should just ignore all external broken links?

comment:2 Changed 10 years ago by Malcolm Tredinnick

-1 on automatically ignoring external broken links. There's a lot of valuable intelligence to be gleaned from that: handling common mistakes (e.g. people not URL-encoding things correctly), spotting when URL accidentally moved or was renamed. Allowing it to be configurable is probably reasonable. Removing the facility which is actually useful today would not be so cool.

comment:3 Changed 8 years ago by Eric Holscher

Component: UncategorizedCore framework

comment:4 Changed 8 years ago by Chris Beaven

Has patch: set
Patch needs improvement: set
Severity: Normal
Type: New feature

comment:5 Changed 7 years ago by Aymeric Augustin

Easy pickings: unset
Needs documentation: set
Needs tests: set
Triage Stage: Design decision neededAccepted
UI/UX: unset

We could change SEND_BROKEN_LINK_EMAILS to accept 'none', 'internal' and 'all' as valid values.

True and False would be interpreted as 'all' and 'none'for backwards compatibility.

The change would have to be explained in the release notes.

Changed 7 years ago by Will Boyce

Attachment: SBLE_internal_81e644e.diff added

comment:6 Changed 7 years ago by Will Boyce

Cc: Will Boyce added
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Updated patch to meet aaugustin's notes and include documentation/tests.

comment:7 Changed 7 years ago by Aymeric Augustin

Needs documentation: set
Owner: changed from nobody to Aymeric Augustin

At first sight the patch looks good. It just needs an explanation of the difference between "all" and "internal" in error-reporting.txt, and a paragraph in the release notes.

comment:8 Changed 7 years ago by Aymeric Augustin

Owner: changed from Aymeric Augustin to nobody

comment:9 Changed 6 years ago by Aymeric Augustin

Resolution: duplicate
Status: newclosed

Since my last comment, I split out this feature in its own middleware, and I deprecated SEND_BROKEN_LINK_EMAILS.

#20099 will make it easier to customize the behavior to your liking, by subclassing this middleware.

Note: See TracTickets for help on using tickets.
Back to Top