Code

Opened 5 years ago

Closed 16 months ago

#10206 closed Bug (wontfix)

admin/auth/user/* templates should be in django.contrib.auth app

Reported by: izibi Owned by: SmileyChris
Component: contrib.admin Version: 1.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In case somebody wants to create a own auth app with a user model he might get a problem with these templates in the admin.

So these templates should be moved to the django.contrib.auth app to prevent this problem.

Attachments (0)

Change History (5)

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

I'm pretty sure these templates are admin-specific.

comment:2 Changed 3 years ago by SmileyChris

  • Owner changed from nobody to SmileyChris
  • Severity set to Normal
  • Status changed from new to assigned
  • Triage Stage changed from Design decision needed to Accepted
  • Type set to Bug

Admin specific, but completely in context to the auth application. If the auth app is not installed, these templates should technically not be accessible.

comment:3 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:4 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:5 Changed 16 months ago by aaugustin

  • Resolution set to wontfix
  • Status changed from assigned to closed

admin requires auth; "the auth app is not installed" isn't really possible.

The other way round is possible: you can use auth without the admin. In that case, the current templates wouldn't work, because they extend admin/base.html which wouldn't be accessible.

Therefore keeping these templates in the admin app is correct.

One could argue that "using the admin with an API-compatible re-implementation of auth that requires different templates" is possible, but that's much less common than "using auth but not the admin", all the more since Django now supports custom user models.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.