Code

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10202 closed (fixed)

When the high mark is 0 on a queryset .count() returns the full number instead of 0

Reported by: Alex Owned by: Alex
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Though this is a bit of an edge case(and not realistic) it's a trivial fix.

Attachments (2)

count-0.diff (949 bytes) - added by Alex 5 years ago.
10202-r9814.diff (1.6 KB) - added by ramiro 5 years ago.
More nitpicking, Fix another Query high_mark comparison against None corner case, add a test and move tests to under regressiontests

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Alex

Changed 5 years ago by ramiro

More nitpicking, Fix another Query high_mark comparison against None corner case, add a test and move tests to under regressiontests

comment:1 Changed 5 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [9924]) Fixed #10202 -- Fixed another couple of slicing edge-cases with querysets.

Patch from Alex Gaynor and Ramiro Morales.

comment:3 Changed 5 years ago by mtredinnick

(In [9925]) [1.0.X] Fixed #10202 -- Fixed another couple of slicing edge-cases with querysets.

Patch from Alex Gaynor and Ramiro Morales.

Backport of r9924 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.