Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#10184 closed (fixed)

pickled QueryDicts lose multiple-values.

Reported by: Andre LeBlanc <andrepleblanc@…> Owned by: Alex Gaynor
Component: HTTP handling Version: master
Severity: Keywords: QueryDict pickle session
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Pickling a querydict with multiple values for the same key causes it to only retain the one of its values. attached a patch against tests/regressiontests/httpwrappers/tests.py including a new test to pickle multi-valued querydicts which fails on latest SVN.

Attachments (4)

querydict_test.patch (642 bytes) - added by Andre LeBlanc <andrepleblanc@…> 8 years ago.
QueryDict test
querydict-pickle.diff (2.1 KB) - added by Alex Gaynor 8 years ago.
querydict-pickle.2.diff (2.0 KB) - added by Alex Gaynor 8 years ago.
fixed issue, removed dead code
querydict-pickle.3.diff (2.0 KB) - added by Alex Gaynor 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Andre LeBlanc <andrepleblanc@…>

Attachment: querydict_test.patch added

QueryDict test

Changed 8 years ago by Alex Gaynor

Attachment: querydict-pickle.diff added

comment:1 Changed 8 years ago by Alex Gaynor

Has patch: set
Owner: changed from nobody to Alex Gaynor
Triage Stage: UnreviewedAccepted

Changed 8 years ago by Alex Gaynor

Attachment: querydict-pickle.2.diff added

fixed issue, removed dead code

comment:2 Changed 8 years ago by Alex Gaynor

milestone: 1.1

Changed 8 years ago by Alex Gaynor

Attachment: querydict-pickle.3.diff added

comment:3 Changed 8 years ago by Jacob

Triage Stage: AcceptedReady for checkin

comment:4 Changed 8 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [10240]) Fixed #10184: QueryDicts with multiple values can now be safely pickled. Thanks, Alex Gaynor.

comment:5 Changed 8 years ago by Jacob

(In [10279]) [1.0.X] Fixed #10184: QueryDicts with multiple values can now be safely pickled. Thanks, Alex Gaynor.

Backport of [10240] from trunk.

comment:6 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top