Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10184 closed (fixed)

pickled QueryDicts lose multiple-values.

Reported by: Andre LeBlanc <andrepleblanc@…> Owned by: Alex
Component: HTTP handling Version: master
Severity: Keywords: QueryDict pickle session
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Pickling a querydict with multiple values for the same key causes it to only retain the one of its values. attached a patch against tests/regressiontests/httpwrappers/tests.py including a new test to pickle multi-valued querydicts which fails on latest SVN.

Attachments (4)

querydict_test.patch (642 bytes) - added by Andre LeBlanc <andrepleblanc@…> 5 years ago.
QueryDict test
querydict-pickle.diff (2.1 KB) - added by Alex 5 years ago.
querydict-pickle.2.diff (2.0 KB) - added by Alex 5 years ago.
fixed issue, removed dead code
querydict-pickle.3.diff (2.0 KB) - added by Alex 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by Andre LeBlanc <andrepleblanc@…>

QueryDict test

Changed 5 years ago by Alex

comment:1 Changed 5 years ago by Alex

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to Alex
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by Alex

fixed issue, removed dead code

comment:2 Changed 5 years ago by Alex

  • milestone set to 1.1

Changed 5 years ago by Alex

comment:3 Changed 5 years ago by jacob

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10240]) Fixed #10184: QueryDicts with multiple values can now be safely pickled. Thanks, Alex Gaynor.

comment:5 Changed 5 years ago by jacob

(In [10279]) [1.0.X] Fixed #10184: QueryDicts with multiple values can now be safely pickled. Thanks, Alex Gaynor.

Backport of [10240] from trunk.

comment:6 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.