Code

Opened 5 years ago

Closed 5 years ago

#10173 closed (wontfix)

Add a setting to set up pg binaries for test_runner

Reported by: laureline.guerin@… Owned by: nobody
Component: GIS Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Context: postgres/postgis.

For gis testing, when test database is created, pg commands are executed:

  • createlang (options) plpgsql
  • psql (options) -f <postgis files>

It would be great if both pg binary pathes could be set in settings, for example:

POSTGRES_PSQL_PATH = '/path/to/psql'
POSTGRES_CREATELANG_PATH = '/path/to/createlang'

Attachments (1)

django_pg_bin_test_runner.diff (1.2 KB) - added by laureline.guerin@… 5 years ago.
Patch for described changes

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by laureline.guerin@…

Patch for described changes

comment:1 Changed 5 years ago by ramiro

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Can't this be solved externally to Django by setting the PATH envvar?. It seems to me that if Django should incorporate one additional setting to store the full path for every external command executed by a helper script we will end with a huge number of such settings.

comment:2 Changed 5 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

Yeah, this is becoming settings overload. It's a sysadmin issue: making sure the right binaries can be found.

if these binaries really are all over the place on different distros, or not on standard paths normally, then the more traditional solution would be an environment variable to declare which binary should be run. That can then be set in the users environment. Wontfixing the current approach. Seems a bit too specialised and not really the right approach.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.