Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#10159 closed (fixed)

Fix F() expressions to work on geographic fields.

Reported by: jbronn Owned by: jbronn
Component: GIS Version: master
Severity: Keywords: gis expression where
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently, users will receive a TypeError when trying to use a F() expression on geographic field. The attached patch is a preliminary fix and needs tests.

Attachments (3)

geowherenode_expressions_fix.diff (1.7 KB) - added by jbronn 8 years ago.
geowherenode_expressions_fix_v2.diff (8.1 KB) - added by jbronn 8 years ago.
Fix, tests, and some cleanup.
geowherenode_expressions_fix_v3.diff (16.1 KB) - added by jbronn 8 years ago.
Now takes into account different SRIDs.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by jbronn

comment:1 Changed 8 years ago by jbronn

Needs documentation: set
Needs tests: set
Patch needs improvement: unset

Changed 8 years ago by jbronn

Fix, tests, and some cleanup.

comment:2 Changed 8 years ago by jbronn

This current patches don't take into account if the geometry fields are in different SRIDs, d'oh.

Changed 8 years ago by jbronn

Now takes into account different SRIDs.

comment:3 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:4 Changed 8 years ago by Alex Gaynor

Triage Stage: UnreviewedAccepted

comment:5 Changed 8 years ago by jbronn

Resolution: fixed
Status: newclosed

(In [9963]) Fixed #10159 -- F() expressions now work on geographic fields. The tests are in relatedapp, which has been retrofitted to work with Oracle (minus the prior offending tests). I'm back.

comment:6 Changed 8 years ago by jbronn

milestone: 1.1

comment:7 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top