Opened 7 years ago

Closed 7 years ago

#10144 closed (duplicate)

get_comment_app calls __import__ with strings instead of dictionaries for 2nd and 3rd arguments

Reported by: jfenwick Owned by: jfenwick
Component: Testing framework Version: 1.0
Severity: Keywords: comments jython
Cc: leosoto Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by ramiro)

When the comment_tests test is run under jython, I get this error:

======================================================================
ERROR: testGetCommentApp (regressiontests.comment_tests.tests.app_api_tests.CommentAppAPITests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jacob/projects/djython/django-1.0.X/tests/regressiontests/comment_tests/tests/app_api_tests.py", line 11, in testGetCommentApp
    self.assertEqual(comments.get_comment_app(), comments)
  File "/Users/jacob/projects/djython/django-1.0.X/django/contrib/comments/__init__.py", line 20, in get_comment_app
    package = __import__(comments_app, '', '', [''])
  File "/Users/jacob/projects/djython/django-1.0.X/django/contrib/comments/__init__.py", line 20, in get_comment_app
    package = __import__(comments_app, '', '', [''])
TypeError: str indices must be integers

The problem is that the import function is taking a string for the second and third arguments when the parameters should be dictionaries. Python seems to coerce the strings into the correct format, but jython does not.

Here is the patch, which should be applied to all version of django:

svn diff init.py

Index: __init__.py
===================================================================
--- __init__.py	(revision 9791)
+++ __init__.py	(working copy)
@@ -17,7 +17,7 @@
 
     # Try to import the package
     try:
-        package = __import__(comments_app, '', '', [''])
+        package = __import__(comments_app, globals(), locals(), [''])
     except ImportError:
         raise ImproperlyConfigured("The COMMENTS_APP setting refers to "\
                                    "a non-existing package.")

Attachments (2)

patch.txt (569 bytes) - added by jfenwick 7 years ago.
Patch for init.py
patch2.txt (613 bytes) - added by jfenwick 7 years ago.
Did the svn diff from the trunk instead of on the file (oops)

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by jfenwick

Patch for init.py

comment:1 Changed 7 years ago by ramiro

  • Description modified (diff)

(reformatted description)

comment:2 Changed 7 years ago by jfenwick

  • Owner changed from nobody to jfenwick
  • Status changed from new to assigned

Changed 7 years ago by jfenwick

Did the svn diff from the trunk instead of on the file (oops)

comment:3 Changed 7 years ago by leosoto

  • Cc leosoto added
  • Keywords jython added

comment:4 Changed 7 years ago by jacob

  • Resolution set to duplicate
  • Status changed from assigned to closed

Duplicate of (well, would be solved by) #8193.

Note: See TracTickets for help on using tickets.
Back to Top