#10138 closed (fixed)
Documentation should mention that loaddata does not call custom save or pre_save signals
Reported by: | John Shimek | Owned by: | Kevin Kubasik |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Keywords: | kkmegapatch | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I have a custom save() method on a model, and I realized it isn't called during the loaddata. The loaddata command creates a set of DeserializedObject objects, each of which contain an object being loaded from the fixture. According to the DeserializedObject.save() method:
def save(self, save_m2m=True): # Call save on the Model baseclass directly. This bypasses any # model-defined save. The save is also forced to be raw. # This ensures that the data that is deserialized is literally # what came from the file, not post-processed by pre_save/save # methods. models.Model.save_base(self.object, raw=True)
In my case, I would like my save method on my model called, but that is easy to remedy for a one time load. In either case, it would be nice to have this documented.
I also found ticket #8399 which talks about the post_save signal being called. I don't know if it is just the pre_save signal and model's save methods not called, but post_save is. Or post_save isn't anymore and that is an old ticket that can be closed.
I will try to write a doc patch soon unless someone else beats me to it.
Attachments (1)
Change History (6)
by , 16 years ago
Attachment: | patch-10138.diff added |
---|
comment:1 by , 16 years ago
Has patch: | set |
---|
I took a first stab at adding the documentation. I would like someone who understands the internals better glance over it to see I described it correctly.
comment:2 by , 16 years ago
milestone: | → 1.1 |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 16 years ago
Keywords: | kkmegapatch added |
---|---|
Owner: | changed from | to
docs patch