Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#10138 closed (fixed)

Documentation should mention that loaddata does not call custom save or pre_save signals

Reported by: John Shimek Owned by: Kevin Kubasik
Component: Documentation Version: master
Severity: Keywords: kkmegapatch
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


I have a custom save() method on a model, and I realized it isn't called during the loaddata. The loaddata command creates a set of DeserializedObject objects, each of which contain an object being loaded from the fixture. According to the method:

def save(self, save_m2m=True):
  # Call save on the Model baseclass directly. This bypasses any
  # model-defined save. The save is also forced to be raw.
  # This ensures that the data that is deserialized is literally
  # what came from the file, not post-processed by pre_save/save
  # methods.
  models.Model.save_base(self.object, raw=True)

In my case, I would like my save method on my model called, but that is easy to remedy for a one time load. In either case, it would be nice to have this documented.

I also found ticket #8399 which talks about the post_save signal being called. I don't know if it is just the pre_save signal and model's save methods not called, but post_save is. Or post_save isn't anymore and that is an old ticket that can be closed.

I will try to write a doc patch soon unless someone else beats me to it.

Attachments (1)

patch-10138.diff (725 bytes) - added by John Shimek 9 years ago.
docs patch

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by John Shimek

Attachment: patch-10138.diff added

docs patch

comment:1 Changed 9 years ago by John Shimek

Has patch: set

I took a first stab at adding the documentation. I would like someone who understands the internals better glance over it to see I described it correctly.

comment:2 Changed 9 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:3 Changed 9 years ago by Kevin Kubasik

Keywords: kkmegapatch added
Owner: changed from nobody to Kevin Kubasik

comment:4 Changed 9 years ago by Jacob

Resolution: fixed
Status: newclosed

Fixed by [10303].

comment:5 Changed 7 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top