Opened 8 years ago

Closed 4 years ago

#10087 closed New feature (invalid)

Missing models.py in django.contrib.localflavor.fr

Reported by: Lior Gradstein Owned by: nobody
Component: contrib.localflavor Version: 1.0
Severity: Normal Keywords: localflavorsplit
Cc: David Larlet Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

To use french flavored PhoneNumberField in models, one need the models.py file like in django.contrib.localflavor.us.
Here's the diff to add it.

Attachments (1)

models.py.diff (1.5 KB) - added by Lior Gradstein 8 years ago.
french models.py for django.contrib.localflavor

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Lior Gradstein

Attachment: models.py.diff added

french models.py for django.contrib.localflavor

comment:1 Changed 8 years ago by David Larlet

Cc: David Larlet added
Needs documentation: set
Needs tests: unset
Patch needs improvement: set

Thanks for adding this, size in db_type methods should be limited to 5 and 14 respectively (as forms validate those).

Note that documentation is missing too, do you plan to add it?

comment:2 Changed 8 years ago by Jacob

Triage Stage: UnreviewedAccepted

Yup, documentation and tests will be required to check this in.

comment:3 Changed 6 years ago by Chris Beaven

Severity: Normal
Type: New feature

comment:4 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:6 Changed 4 years ago by Aymeric Augustin

Keywords: localflavorsplit added
Resolution: invalid
Status: newclosed

django.contrib.localflavor is now deprecated — see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Note: See TracTickets for help on using tickets.
Back to Top