Code

Opened 5 years ago

Closed 18 months ago

#10087 closed New feature (invalid)

Missing models.py in django.contrib.localflavor.fr

Reported by: lstep Owned by: nobody
Component: contrib.localflavor Version: 1.0
Severity: Normal Keywords: localflavorsplit
Cc: david Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

To use french flavored PhoneNumberField in models, one need the models.py file like in django.contrib.localflavor.us.
Here's the diff to add it.

Attachments (1)

models.py.diff (1.5 KB) - added by lstep 5 years ago.
french models.py for django.contrib.localflavor

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by lstep

french models.py for django.contrib.localflavor

comment:1 Changed 5 years ago by david

  • Cc david added
  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement set

Thanks for adding this, size in db_type methods should be limited to 5 and 14 respectively (as forms validate those).

Note that documentation is missing too, do you plan to add it?

comment:2 Changed 5 years ago by jacob

  • Triage Stage changed from Unreviewed to Accepted

Yup, documentation and tests will be required to check this in.

comment:3 Changed 3 years ago by SmileyChris

  • Severity set to Normal
  • Type set to New feature

comment:4 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:5 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:6 Changed 18 months ago by aaugustin

  • Keywords localflavorsplit added
  • Resolution set to invalid
  • Status changed from new to closed

django.contrib.localflavor is now deprecated — see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.