Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#10047 closed (duplicate)

TemporaryFile.seek has bad interface under Windows NT

Reported by: ftartaggia@… Owned by: jkistler
Component: File uploads/storage Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

(see also: closed ticket #7769)

module: django.core.files.temp.py

Under Windows NT platform, a NamedTemporaryFile is a TemporaryFile, whose 'seek' method misses 'whence' argument.

I suppose that line 52 should be changed from:

def seek(self, offset): return self.file.seek(offset)

to:

def seek(self, *args): return self.file.seek(*args).

Attachments (1)

patch.diff (1.2 KB) - added by jkistler 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by ftartaggia@…

  • Has patch set
  • milestone set to post-1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version changed from 1.0 to SVN

comment:2 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:3 Changed 6 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 6 years ago by jkistler

  • Owner changed from nobody to jkistler
  • Status changed from new to assigned

Changed 6 years ago by jkistler

comment:5 Changed 6 years ago by mitsuhiko

  • Resolution set to fixed
  • Status changed from assigned to closed

This one was fixed by the patch in #9344.

comment:6 Changed 6 years ago by Alex

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 6 years ago by Alex

  • Resolution set to duplicate
  • Status changed from reopened to closed

This is actually a dupe.

comment:8 Changed 4 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top