Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#10047 closed (duplicate)

TemporaryFile.seek has bad interface under Windows NT

Reported by: ftartaggia@… Owned by: Jeff Kistler
Component: File uploads/storage Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

(see also: closed ticket #7769)

module: django.core.files.temp.py

Under Windows NT platform, a NamedTemporaryFile is a TemporaryFile, whose 'seek' method misses 'whence' argument.

I suppose that line 52 should be changed from:

def seek(self, offset): return self.file.seek(offset)

to:

def seek(self, *args): return self.file.seek(*args).

Attachments (1)

patch.diff (1.2 KB) - added by Jeff Kistler 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by ftartaggia@…

Has patch: set
milestone: post-1.0
Version: 1.0SVN

comment:2 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:3 Changed 8 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:4 Changed 8 years ago by Jeff Kistler

Owner: changed from nobody to Jeff Kistler
Status: newassigned

Changed 8 years ago by Jeff Kistler

Attachment: patch.diff added

comment:5 Changed 8 years ago by Armin Ronacher

Resolution: fixed
Status: assignedclosed

This one was fixed by the patch in #9344.

comment:6 Changed 8 years ago by Alex Gaynor

Resolution: fixed
Status: closedreopened

comment:7 Changed 8 years ago by Alex Gaynor

Resolution: duplicate
Status: reopenedclosed

This is actually a dupe.

comment:8 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top