BaseModelFormSet's method save_existing_objects uses form.changed_data instead of form.has_changed()
|Reported by:||karihre||Owned by:||nobody|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
The method save_existing_objects uses form.changed_data in an if statement instead of form.has_changed() (which only does bool(self.changed_data) ) not enabling people to overload the has_changed() method for custom behavior.
The method save_new_objects in the same class uses the has_changed() method for the same purpose so I can't figure out why it is done differently in the save_existing_objects method.
I have attached a patch to fix this.
Change History (6)
Changed 7 years ago by karihre
comment:1 Changed 7 years ago by jacob
- milestone set to 1.1
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted